-
Notifications
You must be signed in to change notification settings - Fork 82
IBX-10885: Document Content Type search API #2946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Preview of modified filesPreview of modified Markdown: |
code_samples/api/public_php_api/src/Command/FindContentTypeCommand.php
Outdated
Show resolved
Hide resolved
docs/search/content_type_search_reference/content_type_criteria.md
Outdated
Show resolved
Hide resolved
code_samples/api/public_php_api/src/Command/FindContentTypeCommand.php
Outdated
Show resolved
Hide resolved
code_samples/api/public_php_api/src/Command/FindContentTypeCommand.php
Outdated
Show resolved
Hide resolved
code_samples/api/public_php_api/src/Command/FindContentTypeCommand.php
Outdated
Show resolved
Hide resolved
code_samples/api/public_php_api/src/Command/FindContentTypeCommand.php
Outdated
Show resolved
Hide resolved
code_samples/api/public_php_api/src/Command/FindContentTypeCommand.php
Outdated
Show resolved
Hide resolved
docs/search/content_type_search_reference/content_type_criteria.md
Outdated
Show resolved
Hide resolved
mnocon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Just a couple of suggestions from me
| #[AsCommand( | ||
| name: 'doc:find_content_types', | ||
| description: 'Lists content types that match specific criteria.' | ||
| )] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Friendly reminder that this will not work on 4.6 - and needs to be downgraded (I can help with that if needed).
In general it's easier to write code for 4.6 and then update it to v5 with Rector - we don't have Rector downgrades configured (if they are doable at all)
docs/search/content_type_search_reference/content_type_criteria.md
Outdated
Show resolved
Hide resolved
docs/search/content_type_search_reference/content_type_sort_clauses.md
Outdated
Show resolved
Hide resolved
docs/search/content_type_search_reference/content_type_sort_clauses.md
Outdated
Show resolved
Hide resolved
docs/search/content_type_search_reference/content_type_criteria.md
Outdated
Show resolved
Hide resolved
|
@mnocon I made the changes you suggested but RTD is down, so no way to see it apart from a local build. |
Co-authored-by: Bartek Wajda <bartlomiej.wajda@ibexa.co>
code_samples/ change report
|
mnocon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Document Content Type search API
Checklist